waitAfterCommandFinishesExecution failPoint's activation count can be incremented multiple times per access

    • Type: Bug
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Networking & Observability
    • ALL
    • N&O 2026-04-27, N&O 2026-05-11, N&O 2025-05-25
    • 0
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      The waitAfterCommandFinishesExecution failPoint is activated via a call to executeIf. If the predicate provided to executeIf, the action provided is activated and the activation count is incremented. In this specific case, CurOpFailpointHelpers::waitWhileFailPointEnabled is called.

      Within CurOpFailpointHelpers::waitWhileFailPointEnabled, a second executeIf is called on the failPoint, incrementing the activation count again. Within that call, shouldFail() is called, incrementing the activation count yet again.

      This is responsible for BF-38502, in which the failPoint is expected to be entered exactly one time per thread, but because a single hit of the failPoint can register multiple activations, there is a race condition where a single thread can register enough fail point activations to unblock the test before enough requests are queued leading to the failure seen in BF-38502.

            Assignee:
            Unassigned
            Reporter:
            Cole Harbeck
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: