Address TODO comments in PlanExecutorExpress::readyPlanExecution about yield behavior

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Duplicate
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Execution
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      There are two TODO comments reading "Is this the desired behavior?" in PlanExecutorExpress<Plan>::readyPlanExecution:

      1. In the WaitingForYield overload — after logging the write conflict and backoff, the code calls _plan.temporarilyReleaseResourcesAndYield with a no-op callback.
      2. In the WaitingForBackoff overload — same pattern after handling a TemporarilyUnavailable exception.

      These TODOs were introduced in SERVER-83759. The question is whether yielding with a no-op callback is the correct behavior, or if a meaningful operation should be performed during the yield. This needs investigation and either confirmation that the behavior is correct (removing the TODOs) or a fix.

            Assignee:
            Niels Lohmann
            Reporter:
            Tommaso Tocci
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: