[SERVER-12476] assert() calls that can't fail because of constant-value arguments - MongoDB Jira

XML

Word

Printable

JSON

There are some assert() calls in jstests/ that will never fail because the first argument is a constant value:

$ egrep -nirI "assert\s*\(\s*[1-9]\s*," *

core/batch_api_ordered.js:117:    assert(1, result.getWriteErrorCount());

core/batch_api_unordered.js:43:    assert(1, result.getWriteErrorCount());

core/batch_api_unordered.js:81:    assert(1, result.getWriteErrorCount());

core/batch_api_unordered.js:115:    assert(3, result.getWriteErrorCount());

sharding/diffservers1.js:13:assert( 3 , test1.count() );

sharding/movePrimary1.js:11:    assert( 3 , c.count() );

sharding/sync7.js:19:	assert( 3, c.count() );

Version: 56e6f5ac4bbff54b95ce956823e4b80fc6769bc9

is related to

SERVER-21087 Some uses of assert.throws() always pass

SERVER-20774 Force assert() to accept only booleans