The metric name is always a static StringData from metric_names.h so it is guaranteed to survive for the lifetime of the program. Thus, we can use it as the key to the map of metrics stored in MetricsService which would simplify the code a little and prevent some needless string copies.