Address compile errors for macos variants

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Fixed
    • Priority: Major - P3
    • 9.0.0-rc0
    • Affects Version/s: 9.0.0-rc0
    • Component/s: None
    • None
    • Cluster Scalability
    • Fully Compatible
    • ALL
    • ClusterScalability 27Apr-11May
    • 200
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      From BF-43036.

      Summary

      The specific error from the most recent BFG:

      [2026/04/27 22:54:23.762] src/mongo/db/s/resharding/resharding_donor_post_cloning_delta_collector_test.cpp:69:10: error: 'searchIndexExistsForCollection' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override][2026/04/27 22:54:23.762]    69 |     bool searchIndexExistsForCollection(OperationContext* opCtx, const NamespaceString& nss) {[2026/04/27 22:54:23.762]       |          ^[2026/04/27 22:54:23.762] src/mongo/db/s/resharding/resharding_coordinator_service_external_state.h:67:18: note: overridden virtual function is here[2026/04/27 22:54:23.762]    67 |     virtual bool searchIndexExistsForCollection(OperationContext* opCtx,[2026/04/27 22:54:23.762]       |                  ^[2026/04/27 22:54:23.762] 1 error generated. 

      An override tag is needed, as -Winconsistent-missing-override requires it. Difference in compiler flags must have made this a macos-only compile failure. 

      Root Cause

      This change was introduced in SERVER-120851 with PR 52359.

      Fix

      An override tag is needed in the following files to satisfy the -Winconsistent-missing-override tag.

      • src/mongo/db/s/resharding/resharding_coordinator_service_test.cpp
      • src/mongo/db/s/resharding/resharding_donor_post_cloning_delta_collector_test.cpp

      PR created https://github.com/10gen/mongo/pull/52768


      Additional Error

      See parsley logs with failures.

      Another error on macos variants is preventing the build from being green. This is an unrelated compile error likely introduced with SERVER-123337.

      [2026/04/28 11:17:13.783] src/mongo/util/assert_util_test.cpp:596:5: error: use of undeclared identifier 'raise'
      [2026/04/28 11:17:13.783]   596 |     raise(SIGSEGV);
      [2026/04/28 11:17:13.783]       |     ^
      [2026/04/28 11:17:13.783] src/mongo/util/assert_util_test.cpp:699:5: error: use of undeclared identifier 'raise'
      [2026/04/28 11:17:13.783]   699 |     raise(SIGSEGV);
      [2026/04/28 11:17:13.783]       |     ^
      [2026/04/28 11:17:13.783] src/mongo/util/assert_util_test.cpp:708:5: error: use of undeclared identifier 'raise'
      [2026/04/28 11:17:13.783]   708 |     raise(SIGSEGV);
      [2026/04/28 11:17:13.783]       |     ^
      [2026/04/28 11:17:13.783] src/mongo/util/assert_util_test.cpp:726:5: error: use of undeclared identifier 'raise'
      [2026/04/28 11:17:13.783]   726 |     raise(SIGSEGV);
      [2026/04/28 11:17:13.783]       |     ^
      [2026/04/28 11:17:13.783] 4 errors generated.
      

      Fix

      Add a <csignal> header to include the raise method.

            Assignee:
            Jordan Glassley
            Reporter:
            Jordan Glassley
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: