Refactor SBE VM helper functions to accept TagValueView instead of raw (TypeTags, Value) pairs

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Fixed
    • Priority: Major - P3
    • 9.0.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Execution
    • Fully Compatible
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Several free functions and helper functions across the SBE VM still take raw (value::TypeTags xTag, value::Value xValue) parameter pairs. Now that the builtin functions and generic helpers have been migrated to TagValueView/TagValueMaybeOwned, their call sites already hold TagValueView objects and split them manually with .tag, .value. Collapsing each pair into a single TagValueView parameter removes that splitting and keeps the value together as a unit.

      Functions in scope (at minimum):

      • getDate(TypeTags, Value) in vm_datetime.cpp — callers in block-processing loops pass raw (tag, val) loop variables
      • Any additional utility functions across vm_builtin_*.cpp, vm_block.cpp, and other SBE VM files that follow the same (TypeTags xTag, Value xValue) pattern and are called exclusively from converted builtins

      This is a catch-all for utility-function parameter cleanup that is out of scope for the individual per-file builtin refactor tickets in SPM-4577.

            Assignee:
            Evan Bergeron
            Reporter:
            Mihai Andrei
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: