Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-12720

Needless inclusion of file_allocator in util/util.cpp creates C++ client driver dependency on posix_fadvise

    • Type: Icon: Improvement Improvement
    • Resolution: Done
    • Priority: Icon: Minor - P4 Minor - P4
    • 2.6.0-rc0
    • Affects Version/s: None
    • Component/s: Internal Client
    • None
    • Fully Compatible

      util/util.cpp, which implements some of goodies.h, includes file_allocator.h, but only acquires the StaticObserver from it. However, by pulling in file_allocator, it creates a dependency on posix_fadvise.cpp, which is then also required in the driver.

      Changing util.cpp to only require mutex.h to get the static observer removes both file_allocator.h and posix_fadvise.h from the files required to build the client driver.

            Assignee:
            Unassigned Unassigned
            Reporter:
            andrew.morrow@mongodb.com Andrew Morrow (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: