Remove duplication in oplog entry unit tests

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Storage Execution
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Goal

      One test per distinct applyOps shape, each asserting the same set of predicates.

      Problem

      The ApplyOps* tests in oplog_entry_test.cpp already give us one test per applyOps shape, each asserting all the relevant predicates. But the file also has focused ApplyOpsIsMarkedRetryable* tests that duplicate that same BSON setup while asserting only applyOpsIsMarkedRetryable.

      Cleanup

      Delete (shape already covered by an ApplyOps* test):

      • ApplyOpsIsMarkedRetryableMultiDocTxnIsNotMarked → covered by ApplyOpsEndMultiEntryTransaction
      • ApplyOpsIsMarkedRetryableNotInSessionIsNotMarked → covered by ApplyOpsNotInSession
      • ApplyOpsIsMarkedRetryableAppliedAtomically / ...WithPrevOpTime → covered by ApplyOpsAppliedAtomicallyIsNotTransaction

      Add dedicated shape tests that assert all the predicates (like the other ApplyOps* tests):

      • internal session for retryable writes (replacing ApplyOpsIsMarkedRetryableExcludesInternalSessionForRetryableWrite)
      • non-applyOps with multiOpType (replacing ApplyOpsIsMarkedRetryableNonApplyOpsWithMultiOpTypeIsNotMarked)

            Assignee:
            Unassigned
            Reporter:
            Shin Yee Tan
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: