Refactor join opt explain code to avoid copying ceSamplingMetadata

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Optimization
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      In SERVER-128714, we added a copy of ceSamplingMetadata to pass into PlanExplainerClassicRuntimePlannerForSBE meaning that there are now 2 instances of the ceSamplingMetadata map - one in PlanExplainerImpl and the other in PlanExplainerClassicRuntimePlannerForSBE.

      This leads to messy code and introduces the possibility of a bug with a silent failure in the future where the ceSamplingMetadata information returned is wrong due to accessing the wrong copy. We should refactor this codepath, e.g. by modifying the responsibilities/structure of PlanExplainerData to make the ownership and passing around of ceSamplingMetadata extremely clear.

            Assignee:
            Unassigned
            Reporter:
            Naafiyan Ahmed
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: