Remove dead DocumentSourceInternalSearchIdLookUp::createFromBson()

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Integration
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Now that $_internalSearchIdLookup is built through the StageParams registry, its static DocumentSourceInternalSearchIdLookUp::createFromBson() is dead code: the stage is not registered via REGISTER_DOCUMENT_SOURCE or either StageParams bridge macro, and the only remaining reference to createFromBson() is a helper in document_source_visitor_docs_needed_bounds_test.cpp.

      This ticket should remove the dead code and migrate the test helper to construct the stage via its public constructor instead.

            Assignee:
            Daniel Segel
            Reporter:
            Daniel Segel
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: