Summary

The jstest jstests/noPassthrough/admission/ingress_request_rate_limiter_scatter_gather_error_propagation.js started failing on mongodb-mongo-master after PR #56718 (SERVER-129657) merged (~2026-07-06). The test asserts stale values for overload retry counters that SERVER-129657 has now corrected.

Example failing task: enterprise_amazon_linux2023_arm64_all_feature_flags_noPassthrough

Root cause

The test was merged before SERVER-129657 landed. At the time, it contained a TODO(SERVER-129657) acknowledging that the retry counters over-counted: numRetriesDueToOverloadAttempted and numOperationsRetriedAtLeastOnceDueToOverload were incremented whenever a SystemOverloadedError label was seen, even when no retry actually occurred (e.g. when the retry was aborted during the backoff period before dispatch because maxTimeMS expired).

SERVER-129657 fixed the counter logic so those metrics are no longer bumped when no retry happens.

Fix

Flip all asserted counters from 1 to 0 and remove the now-obsolete TODO(SERVER-129657) comment.

(The fix is already prepared locally in commit 482429b962906c7b62753f3e92a3ebe7678fcbaf.)

Related

• SERVER-129657 — the fix (PR #56718) that corrected the counter logic and triggered this failure.
• SERVER-127629 — the ticket that added this test.

No BF ticket has been filed for this failure yet.