Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-13158

Scope OID::ourMachine and OID::ourMachineAndPid to oid.cpp rather than class OID

    XMLWordPrintableJSON

Details

    • Icon: Improvement Improvement
    • Resolution: Done
    • Icon: Minor - P4 Minor - P4
    • None
    • None
    • Internal Code
    • None
    • Fully Compatible

    Description

      Having these as class statics visible to header consumers has effects when DLL visibility is in play, in particular the "two variables on one line" thing seems to be baffling MSVC in some bizarre way:

      C:\cygwin\home\andrew\Documents\10gen\dev\opt\include\mongo/bson/oid.h(118) : error C2487: 'ourMachineAndPid' : member of dll interface class may not
      be declared with dll interface

      These statics are private, so they should just be scoped to OID.cpp rather than to class OID.

      We can either fix this in the server codebase and pick it up in the C++ driver repo, or, if not, the C++ driver codebase will make this change.

      Attachments

        Activity

          People

            Unassigned Unassigned
            andrew.morrow@mongodb.com Andrew Morrow (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: