IDL stable-API compat check fails: overloadRetryAfterMS and automaticCEPlanRankingStrategy renamed without compatibility_rules.yml exception

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Fixed
    • Priority: Major - P3
    • 9.1.0-rc0, 9.0.0-rc1
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Integration
    • Fully Compatible
    • ALL
    • v9.0
    • 200
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Description

      test_api_version_compatibility fails on both master and v9.0-staging with:

      IDL compatibility check failed with 2 errors:
      Error in src/mongo/db/error\_labels.idl: ID0092: The parameter 'overloadRetryAfterMS' was present in the stable API but was removed.
      Error in src/mongo/db/query/query\_optimization\_knobs.idl: ID0092: The parameter 'automaticCEPlanRankingStrategy' was present in the stable API but was removed.
      

      Both parameters were renamed (not actually removed) by two unrelated, already-merged changes:
      * SERVER-130142 renamed overloadRetryAfterMS to baseBackoffMS in error_labels.idl
      * SERVER-127563 renamed automaticCEPlanRankingStrategy to internalQueryMixedPlanRankingStrategy in query_optimization_knobs.idl

      Neither change added the corresponding exception to buildscripts/private/idl/compatibility_rules.yml's IGNORE_REMOVED_PARAMETERS_LIST, which is the standard mechanism for this (precedent: SERVER-123189, SERVER-128517).

      This currently fails the required test_api_version_compatibility task on every patch against master and v9.0-staging.

      Fix

      Add both parameter names to IGNORE_REMOVED_PARAMETERS_LIST in buildscripts/private/idl/compatibility_rules.yml, each with a comment citing the rename ticket.

      Related* BF-44661 (build failure tracking this on v9.0)

      • SERVER-130142
      • SERVER-127563

            Assignee:
            Will Buerger
            Reporter:
            Will Buerger
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: