ShardingCoordinator shouldn't tassert in the destructor

ExportXMLWordPrintableJSON

    • Type: Bug
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: 8.3.0, 9.1.0-rc0, 9.0.0
    • Component/s: None
    • None
    • Catalog and Routing
    • ALL
    • 3
    • 🟥 DDL
    • None
    • None
    • None
    • None
    • None
    • None

      The current implementation of ~ShardingCoordinator contains two tasserts. These were invariants before, but were turned into tasserts in SERVER-106445 to avoid crashing too aggressively in DDL coordinators. However, C++ destructors are noexcept by default, so if either tassert ever fires the behavior would be identical to an invariant, because the process would immediately call std::terminate when trying to propagate the exception thrown by the tassert.

            Assignee:
            Unassigned
            Reporter:
            Aitor Esteve Alvarado
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: