Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-13738

Get rid of StackChecker

    • Type: Icon: Task Task
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • 2.7.0
    • Affects Version/s: None
    • Component/s: Internal Code
    • Labels:
    • Fully Compatible

      After discussion, we decided that it does more harm than good.

      Issues with the StackChecker:

      1) Debug builds on linux already use a 50% smaller stack so we would catch getting anywhere near a stack overflow.
      2) It broke in the presence of compiler optimizations and sanitizers (which correctly diagnosed it as a buffer overrun).
      3) Due to 2, it was disabled on all of our builders.
      4) Due to 2, it could never tell us how much stack we actually used in release builds, since optimizations effect stack usage.
      5) It would fail or pass based on your choice of compiler.
      6) Our response to it failing was always just to raise the limit.

            mathias@mongodb.com Mathias Stearn
            mathias@mongodb.com Mathias Stearn
            1 Vote for this issue
            3 Start watching this issue