-
Type:
Improvement
-
Resolution: Unresolved
-
Priority:
Minor - P4
-
None
-
Affects Version/s: None
-
Component/s: None
-
None
-
DevProd Test Infrastructure
-
None
-
None
-
None
-
None
-
None
-
None
-
None
1. Check the cheap case first - for example, we would never have to initialize a Repo() if we fall into this else branch
2. Regarding the if expansions.get("github_pr_number", None): branch above, we could write it like this to avoid enumerating branches
if expansions.get("github_pr_number"): remote_branch_name = expansions["branch_name"] diff_commit = repo.git.merge_base("HEAD", f"refs/heads/{remote_branch_name}")
We use get_diff_revision in a few places to to revolve a diff of what the current
"changes under test" are.
- related to
-
SERVER-139036 Add deterministic lints for backports_required_for_multiversion_tests.yml and resmoke suite yamls to check_feature_flag_tags
-
- Closed
-