ExportXMLWordPrintableJSON

    • Type: Task
    • Resolution: Fixed
    • Priority: Major - P3
    • 9.1.0-rc0, 9.1.0-rc1026
    • Affects Version/s: None
    • Component/s: Bazel
    • None
    • Build OnDeck
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Add JS_STANDALONE=1 to the public defines for mozjs in src/third_party/mozjs/BUILD.bazel, alongside STATIC_JS_API=1. SpiderMonkey's MFBT headers require both settings to declare static-library APIs correctly; without JS_STANDALONE, Windows consumers declare DLL imports. The definition matches the existing generated standalone configuration on every supported platform.

      Extracted from #66298 for review by query-integration-features. Based directly on master and independent of the other team fixes; merge before #66298.

      Validation: bazel build //src/third_party/mozjs:mozjs_with_debug passed on Linux ARM64. A Clang Windows COFF probe using mozilla/Types.h reproduced an MFBT DLL-import reference with STATIC_JS_API alone and produced the direct reference when JS_STANDALONE was also defined. Full Windows linking remains to be validated; standalone cross-build analysis on this host needs the execution-platform fix in #66298. bazel run format passed.

      Linux build results.

            Assignee:
            Daniel Moody
            Reporter:
            Daniel Moody
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: