errnoWithDescription can leak memory on Windows

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Done
    • Priority: Major - P3
    • 3.3.11
    • Affects Version/s: None
    • Component/s: Internal Code
    • Fully Compatible
    • ALL
    • Hide 
              if( errorText ) {
            string x = toUtf8String(errorText);
            for( string::iterator i = x.begin(); i != x.end(); i++ ) {
                if( *i == '\n' || *i == '\r' )
                    break;
                s << *i;
            }
            LocalFree(errorText);
        }
      Show
      if ( errorText ) { string x = toUtf8String(errorText); for ( string::iterator i = x.begin(); i != x.end(); i++ ) { if ( *i == '\n' || *i == '\r' ) break ; s << *i; } LocalFree(errorText); }
    • Platforms 18 (08/05/16)
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Since toUtf8String() can throw, it's possible to miss calling LocalFree(errorText). This should probably be placed in an ON_BLOCK_EXIT.

            Assignee:
            Waley Chen (Inactive)
            Reporter:
            Eric Milkie
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: