ExportXMLWordPrintableJSON

    • Type: Task
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • DB Integration & Observability
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Overview

      Follow-up to [SERVER-131069]. That ticket deletes mocked \$search tests in jstests/with_mongot/search_mocked/ whose coverage is fully replaced by the e2e suites, under the constraint that no deletion may leave a new coverage gap. Twelve files were deferred because deleting each would lose some coverage. This ticket ports those gaps to jstests/with_mongot/e2e/ where real mongot can express them, then deletes the mocked files.

      Scope of Work

      For each file: port the listed gap to e2e, then delete the mocked file. Cases real mongot cannot produce (response injection, exact explain payloads) are kept mocked rather than lost.

      File Coverage lost on deletion Likely portable to e2e?
      search.js mongot error during getMore (error propagation past first batch) Yes — via a failpoint making mongot fail mid-cursor
      search_metadata.js null/missing metadata response injection; missing/empty highlights; highlights-as-subobject-array Injection cases: no (stay mocked)
      search_meta.js slowQueryLog passthrough assertion; \$searchMeta explain with isSearchMeta/remotePlans Explain payload: no (stay mocked)
      search_meta_var.js \$lookup execute-once / cached behavior assertion Yes
      search_beta.js deprecation-warning log assertion (Rarely sampler; unreliable on shared e2e fixtures) Needs a reliable assertion strategy
      search_query_stats.js non-zero docsExamined/keysExamined \$queryStats metrics (e2e only asserts 0/0 on empty collection) Yes
      search_collector_no_passthrough_stage.js merge-forcing case exists in e2e but by a different mechanism (\$group vs \$out on 2 shards) Yes
      search_meta_sharded_one_shard.js single unsplit chunk on a sharded collection scenario not literally reproduced Yes
      search_shard_filtering.js \$lookup-subpipeline orphan-filtering case Yes
      sharded_metadata.js \$searchMeta-inside-a-view merge-location cases Yes
      search_view.js "view re-desugared on each query" only implicit (e2e queries once) Yes — query twice
      search_and_lookup_with_cache.js plan-cache run-twice stress only approximated Yes

      Acceptance Criteria* Each of the 12 files is either deleted with its gap covered by an e2e test, or retained holding only the inherently-mocked cases (with its TODO updated accordingly)

      • No coverage loss relative to today's mocked suites
      • No stale SERVER-131069 TODO markers left behind (grep-verified)

      Technical Notes

      • The per-file cross-reference evidence lives in SERVER-131069's investigation (dispositions, Category B).
      • BUILD.bazel in search_mocked/ and the mocked-suite yml selectors are globs — deletion requires no BUILD or suite edits.
      • Verify suite membership with resmoke.py test-discovery (not list-tags) after deletion.

            Assignee:
            Will Buerger
            Reporter:
            Will Buerger
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: