Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-14536

Helgrind suppressions for race-prone counters.cpp code

    XMLWordPrintable

    Details

      Description

      Various methods in counters.cpp are prone to races, so it makes sense to add them to valgrind.suppressions.


      These OpCounters methods use the RARELY macro, which relies on a static counter that multiple threads can modify:

      OpCounters::gotCommand()
      OpCounters::gotDelete()
      OpCounters::gotGetMore()
      OpCounters::gotInsert()
      OpCounters::gotQuery()
      OpCounters::gotUpdate()

      And NetworkCounter::hit has this comment:

      // don't care about the race as its just a counter

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              kamran.khan Kamran K.
              Reporter:
              kamran.khan Kamran K.
              Participants:
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: