Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-14554

DBRef JS constructor does not accept $db with --js-engine=v8-3.25

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 2.7.4
    • Component/s: JavaScript
    • Labels:
    • Operating System:
      ALL
    • Steps To Reproduce:
      Hide

      scons --js-engine=v8-3.25 -j 8 all && buildscripts/smoke.py jstests/core/shelltypes.js

      Show
      scons --js-engine=v8-3.25 -j 8 all && buildscripts/smoke.py jstests/core/shelltypes.js

      Description

      Various smoke tests fail when built with --js-engine=v8-3.25. I haven't poked into every single one, but the ones I have looked at are all some variation of:

      2014-07-15T05:19:26.528+0100 Error: DBRef needs 2 arguments
      at Error (native)
      at /home/mwhudson/mongo/jstests/core/shelltypes.js:14:5 at /home/mwhudson/mongo/jstests/core/shelltypes.js:14
      failed to load: /home/mwhudson/mongo/jstests/core/shelltypes.js

      so I suspect that they are all or at least mostly symptoms of the same underlying problem.

        Issue Links

          Activity

          Hide
          benety.goh Benety Goh added a comment -

          Michael Hudson-Doyle, it seems that the fix for SERVER-9790 was not ported to v8-3.25.cpp.

          We're working on it now!

          Show
          benety.goh Benety Goh added a comment - Michael Hudson-Doyle , it seems that the fix for SERVER-9790 was not ported to v8-3.25.cpp. We're working on it now!
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

          Message: SERVER-9790 SERVER-14554 (v8-3.25) Add this.$db || db.toString() to DBRef string representation
          Branch: master
          https://github.com/mongodb/mongo/commit/63bca554b175f27451876df5a975f43dc79f55ee

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'} Message: SERVER-9790 SERVER-14554 (v8-3.25) Add this.$db || db.toString() to DBRef string representation Branch: master https://github.com/mongodb/mongo/commit/63bca554b175f27451876df5a975f43dc79f55ee
          Hide
          mwhudson Michael Hudson-Doyle added a comment -

          Hi, seems fixed now, thanks! I guess you're not running CI with v8-3.25? Is there anything I can do to help there? We're probably going to start running arm64 tests ourselves but we're not going to be able to integrate that with your systems for a good while yet.

          Show
          mwhudson Michael Hudson-Doyle added a comment - Hi, seems fixed now, thanks! I guess you're not running CI with v8-3.25? Is there anything I can do to help there? We're probably going to start running arm64 tests ourselves but we're not going to be able to integrate that with your systems for a good while yet.
          Hide
          benety.goh Benety Goh added a comment -

          Unfortunately we don't have a CI for 3.25 yet. We're glad to hear about the arm64 tests - please feel free to file a SERVER ticket and mention either [~matt.kangas@10gen.com] or myself in the comments if you notice any regressions in the test results

          Show
          benety.goh Benety Goh added a comment - Unfortunately we don't have a CI for 3.25 yet. We're glad to hear about the arm64 tests - please feel free to file a SERVER ticket and mention either [~matt.kangas@10gen.com] or myself in the comments if you notice any regressions in the test results

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: