invariant, not dassert on all CollectionMetadata reload codepaths

Because it's very difficult to trace errors that might occur much later in a cluster, production-time invariants should be used on the MetadataLoader/cloneXXX codepaths.