Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-17068

3.0.0-rc6 cannot build with the 3.25 JS engine

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-rc6
    • Fix Version/s: 3.0.0-rc7
    • Component/s: Build
    • Labels:
      None
    • Backwards Compatibility:
      Fully Compatible
    • Operating System:
      ALL
    • Steps To Reproduce:
      Hide

      scons --js-engine=v8-3.25 mongod

      Show
      scons --js-engine=v8-3.25 mongod

      Description

      Build fails for when enabling V8-3.25 for the following reasons:

      1. missing std:: namespace
      2. missing boost:: namespace
      3. Erronous call to logger::globalLogDomain()->shouldLog()

        Issue Links

          Activity

          Hide
          raffopazzo Raffaele Rossi added a comment -
          Show
          raffopazzo Raffaele Rossi added a comment - Please see https://jira.mongodb.org/browse/SERVER-16898 for more details
          Hide
          raffopazzo Raffaele Rossi added a comment -

          So I've got a fix ready. What shall I do? merge it back into my fork's master branch and submit a pull request from there?

          Show
          raffopazzo Raffaele Rossi added a comment - So I've got a fix ready. What shall I do? merge it back into my fork's master branch and submit a pull request from there?
          Hide
          milkie Eric Milkie added a comment -

          Yes I think that should work. We've pulled from your fork before, correct?

          Show
          milkie Eric Milkie added a comment - Yes I think that should work. We've pulled from your fork before, correct?
          Hide
          raffopazzo Raffaele Rossi added a comment -

          Nope. This would be the first I actually contribute. Nobody aver pulled anything from me.
          Any particular recommendation for the commit message? I saw that previous logs report the issue reference number SERVER-xxxxx

          Show
          raffopazzo Raffaele Rossi added a comment - Nope. This would be the first I actually contribute. Nobody aver pulled anything from me. Any particular recommendation for the commit message? I saw that previous logs report the issue reference number SERVER-xxxxx
          Hide
          milkie Eric Milkie added a comment -

          We'll take care of amending the commit message, but do reference "SERVER-17068" in the first line. And be sure to sign the contributor agreement if you haven't already: https://www.mongodb.com/legal/contributor-agreement

          Show
          milkie Eric Milkie added a comment - We'll take care of amending the commit message, but do reference " SERVER-17068 " in the first line. And be sure to sign the contributor agreement if you haven't already: https://www.mongodb.com/legal/contributor-agreement
          Hide
          raffopazzo Raffaele Rossi added a comment -

          I signed the agreement and push my changes to my fork's master branch.
          https://github.com/raffopazzo/mongo/commits/master

          What should I do next?

          Show
          raffopazzo Raffaele Rossi added a comment - I signed the agreement and push my changes to my fork's master branch. https://github.com/raffopazzo/mongo/commits/master What should I do next?
          Hide
          benety.goh Benety Goh added a comment -

          Hi Raffaele Rossi, I'm taking care of the v8 compilation errors. You can pull my changes once they are in master.

          Show
          benety.goh Benety Goh added a comment - Hi Raffaele Rossi , I'm taking care of the v8 compilation errors. You can pull my changes once they are in master.
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

          Message: SERVER-17068 fixed compilation errors

          Based on the following changes to engine_v8.h, engine_v8.cpp and v8_utils.cpp:

          SERVER-13256 Remove shared_ptr from pch.h
          SERVER-13256 Add std namespace qualifications in headers
          SERVER-13256 Add usings and qualifications for names from namespace std
          SERVER-16754 correct shouldLog() to respect the current default component
          Branch: master
          https://github.com/mongodb/mongo/commit/107e3bfcd71936a876231517ee52aa6ca80b7e1d

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'} Message: SERVER-17068 fixed compilation errors Based on the following changes to engine_v8.h, engine_v8.cpp and v8_utils.cpp: SERVER-13256 Remove shared_ptr from pch.h SERVER-13256 Add std namespace qualifications in headers SERVER-13256 Add usings and qualifications for names from namespace std SERVER-16754 correct shouldLog() to respect the current default component Branch: master https://github.com/mongodb/mongo/commit/107e3bfcd71936a876231517ee52aa6ca80b7e1d
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

          Message: SERVER-17068 fixed compilation errors

          Based on the following changes to engine_v8.h, engine_v8.cpp and v8_utils.cpp:

          SERVER-13256 Remove shared_ptr from pch.h
          SERVER-13256 Add std namespace qualifications in headers
          SERVER-13256 Add usings and qualifications for names from namespace std
          SERVER-16754 correct shouldLog() to respect the current default component

          (cherry picked from commit 107e3bfcd71936a876231517ee52aa6ca80b7e1d)
          Branch: v3.0
          https://github.com/mongodb/mongo/commit/a0986ff9cd64e935a37f4d0b254728712866c579

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'} Message: SERVER-17068 fixed compilation errors Based on the following changes to engine_v8.h, engine_v8.cpp and v8_utils.cpp: SERVER-13256 Remove shared_ptr from pch.h SERVER-13256 Add std namespace qualifications in headers SERVER-13256 Add usings and qualifications for names from namespace std SERVER-16754 correct shouldLog() to respect the current default component (cherry picked from commit 107e3bfcd71936a876231517ee52aa6ca80b7e1d) Branch: v3.0 https://github.com/mongodb/mongo/commit/a0986ff9cd64e935a37f4d0b254728712866c579

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: