Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-17790

Build third_party libraries with NDEBUG defined in optimized non-debug builds

    XMLWordPrintableJSON

Details

    • Icon: Task Task
    • Resolution: Done
    • Icon: Major - P3 Major - P3
    • 3.1.9
    • None
    • Build
    • Fully Compatible
    • Build 7 08/10/15, Build 8 08/31/15, Build 9 (09/18/15), Build A (10/09/15)

    Description

      We don't globally define NDEBUG in the tree because we use our own macros to detect optimization or debugging.

      Other libraries in third_party do reference NDEBUG in various ways, and expect it to be set correctly.

      In particular, the following libraries make some sort of reference to NDEBUG:

      • boost-1.56
      • gperftools-2.2
      • pcre-8.30
      • s2
      • snappy-1.1.2
      • v8

      We should enable NDEBUG for all of third party when appropriate. This most likely corresponds to the configuration where we are building with optimization on, and debugging off.

      Attachments

        Activity

          People

            jonathan.reams@mongodb.com Jonathan Reams
            andrew.morrow@mongodb.com Andrew Morrow (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: