"control reaches end of non-void function" errors in GCC with WCE retry loop

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Done
    • Priority: Major - P3
    • 3.0.9, 3.1.3
    • Affects Version/s: None
    • Component/s: Replication
    • None
    • Fully Compatible
    • ALL
    • Hide

      Scons invocation:

      scons -j24 CC=gcc-5 CXX=g++-5 --cache --dbg=on --opt=off --cache-dir=/media/amidvidy/scons_cache/cache --ssl CCFLAGS="-fuse-ld=gold -fdiagnostics-color=always" mongod

      Show
      Scons invocation: scons -j24 CC=gcc-5 CXX=g++-5 --cache --dbg=on --opt=off --cache-dir=/media/amidvidy/scons_cache/cache --ssl CCFLAGS="-fuse-ld=gold -fdiagnostics-color=always" mongod
    • Platform 3 05/15/15
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None

      When the entire function is wrapped in a WCE retry-loop GCC doesn't deduce that a return statement will be reached.

      Error:

      src/mongo/db/repl/minvalid.cpp: In function 'bool mongo::repl::getInitialSyncFlag()':
src/mongo/db/repl/minvalid.cpp:95:5: error: control reaches end of non-void function [-Werror=return-type]
     }
     ^
src/mongo/db/repl/sync.cpp: In member function 'virtual bool mongo::repl::Sync::shouldRetry(mongo::OperationContext*, const mongo::BSONObj&)':
src/mongo/db/repl/sync.cpp:158:5: error: control reaches end of non-void function [-Werror=return-type]
     }
     ^

      Apparently this was happening with gcc 4.9 as well according to spencer.

      Toolchain: gcc 5.1.0 obtained from ubuntu-toolchain-test ppa

      g++-5 -v
gcc version 5.1.0 (Ubuntu 5.1.0-0ubuntu11~14.04.1)

      Note that this only happens on debug builds.

            Assignee:
            Adam Midvidy (Inactive)
            Reporter:
            Adam Midvidy (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: