Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-19147

prefer one arg per line to all args together on the subsequent line

XMLWordPrintableJSON

    • Type: Icon: Improvement Improvement
    • Resolution: Won't Fix
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: 3.1.4
    • Component/s: Build

      I would like this opposite of this diff to be the case, as I find it greatly improves readability:

      Running across 24 cpus
ERROR: Found diff for /home/dannenberg/work/server6071/mongo/src/mongo/db/repl/replication_coordinator_impl_heartbeat.cpp
To fix formatting errors, run /usr/bin/clang-format --style=file -i /home/dannenberg/work/server6071/mongo/src/mongo/db/repl/replication_coordinator_impl_heartbeat.cpp
---
+++
@@ -84,11 +84,8 @@
         timeout = hbRequest.second;
     }

-    const RemoteCommandRequest request(target,
-                                       "admin",
-                                       heartbeatObj,
-                                       BSON(rpc::kReplicationMetadataFieldName << 1),
-                                       timeout);
+    const RemoteCommandRequest request(
+        target, "admin", heartbeatObj, BSON(rpc::kReplicationMetadataFieldName << 1), timeout);
     const ReplicationExecutor::RemoteCommandCallbackFn callback =
         stdx::bind(&ReplicationCoordinatorImpl::_handleHeartbeatResponse,
                    this,
ERROR: Code Style does not match coding style

            Assignee:
            backlog-server-platform DO NOT USE - Backlog - Platform Team
            Reporter:
            matt.dannenberg Matt Dannenberg
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: