Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-19249

Clang-format should allow BSON macro to be used with one key-value pair per line

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Build
    • Labels:

      Description

      ERROR: Found diff for /media/ssd/mongo4/src/mongo/s/catalog/replset/catalog_manager_replica_set_remove_shard_test.cpp
      To fix formatting errors, run /usr/bin/clang-format-3.6 --style=file -i /media/ssd/mongo4/src/mongo/s/catalog/replset/catalog_manager_replica_set_remove_shard_test.cpp
      ---
      +++
      @@ -89,9 +89,8 @@
               onCommand([&](const RemoteCommandRequest& request) {
                   ASSERT_EQUALS(configHost, request.target);
                   ASSERT_EQUALS("config", request.dbname);
      -            BSONObj expectedCreateCmd = BSON("create" << ChangelogType::ConfigNS <<
      -                                             "capped" << true <<
      -                                             "size" << 1024 * 1024 * 10);
      +            BSONObj expectedCreateCmd = BSON("create" << ChangelogType::ConfigNS << "capped" << true
      +                                                      << "size" << 1024 * 1024 * 10);
                   ASSERT_EQUALS(expectedCreateCmd, request.cmdObj);
       
                   return BSON("ok" << 1);
      ERROR: Code Style does not match coding style
      

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: