Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-20642

ThreadPool should use std::deque instead of std::list to hold _pendingTasks

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor - P4
    • Resolution: Fixed
    • None
    • 3.1.9
    • Internal Code
    • None
    • Fully Compatible
    • Platform A (10/09/15)

    Description

      While profiling network_interface_asio_integration_test, which uses a ThreadPool, I found that ~60% of cycles were spent in ThreadPool::schedule(). Changing _pendingTasks from a list to a deque made schedule() take a more reasonable amount of time. The culprit is probably libstdc++ not implementing list::size as an O(1) operation, despite that being mandated by the C++11 standard.

      Attachments

        Activity

          People

            adam.midvidy Adam Midvidy
            adam.midvidy Adam Midvidy
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: