The runCommand methods on the ShardRegistry type that currently take a HostAndPort argument should actually take a ReadPreferenceSetting and either a Shard or a Targeter. The problem with the current form is that the targeter is given a read preference by code trying to run commands against shards in order to derive a HostAndPort. The code trying to run commands is not then obligated (or sometimes even enabled) to appropriately set the $secondaryOk metadata field. Given the uses, a better design would be for the runCommand-like methods to take a Shard or Targeter along with a read preference, and to do targeting and command dispatch together.
Making this change will hopefully eliminate bugs where operations are targeted to secondary nodes without setting the $secondaryOk flag.
- is depended on by
-
SERVER-20764 create_index_gle.js intermittently fails, getLastError returns error "could not target full range of test.user; metadata not found"
- Closed
-
SERVER-20746 --configsvr shouldn't imply --master when in csrs mode
- Closed
- related to
-
SERVER-18194 Commands shouldn't set slaveOk flag for readPreference=PRIMARY
- Closed