Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-20850

clang-format patch build passed lint, but had an error that broke the build

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Tools
    • Labels:

      Description

      The patch at https://evergreen.mongodb.com/build/mongodb_mongo_master_linux_64_77b5a7cd3d8f95c411549c1342b6fb696e352adc_15_10_08_19_37_01
      passed lint, but has en error that broke the lint check on master:

      https://evergreen.mongodb.com/task/mongodb_mongo_master_enterprise_linux_64_amazon_ami_lint_e465af7b99fe2844a621ecb995f59f5f5316cf1d_15_10_09_15_07_21

      My commit to fix it shows the exact formatting error that wasn't detected:

      commit 177e91b765ae7b966bd17a0eadf80635b0417023
      Author: Geert Bosch <geert@mongodb.com>
      Date: Fri Oct 9 12:13:22 2015 -0400

      SERVER-19521: Fix lint

      diff --git a/src/mongo/dbtests/validate_tests.cpp b/src/mongo/dbtests/validate_tests.cpp
      index 1175171..48ee3a8 100644
      — a/src/mongo/dbtests/validate_tests.cpp
      +++ b/src/mongo/dbtests/validate_tests.cpp
      @@ -167,7 +167,7 @@ public:

      { WriteUnitOfWork wunit(&_txn); rs->deleteRecord(&_txn, id1); - wunit.commit(); + wunit.commit(); }

      ASSERT_FALSE(checkValid());

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: