[SERVER-21456] Improve closing connection behavior when stepping down from primary - MongoDB

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Major - P3
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 3.6.3, 3.7.1
Component/s: Replication
Labels:
- bkp
- todo_in_code

Backwards Compatibility:
Fully Compatible
Backport Requested:

v3.6, v3.4
Epic Link:
Avoid closing connections and killing operations on stepdown
Sprint:
Repl 2017-12-04
Linked BF Score:
19

Description

There is a race of tagging and closing connections when stepping down. After the connection is established but before it gets tagged, there's a small window where the connection may be closed on stepdown.

We could fix this by having internal connections tagged in other ways than _isMaster for every incoming connections (maybe logical session?), or only hanging up connections that have locked the database / issued any commands, or not hanging up connections at all but instead just returning a stepdown error.

Attachments

Issue Links

related to

SERVER-31265 Do not terminate connections on endAllSessions that have just been accepted and their tags have not been set yet

Closed

SERVER-24574 Tag internal connections KeepOpen to avoid closing on stepdown

Closed

SERVER-42557 Complete TODO listed in SERVER-21456

Closed

SERVER-43512 Complete TODO listed in SERVER-21456

Closed

SERVER-44228 Complete TODO listed in SERVER-21456

Closed

SERVER-44336 Complete TODO listed in SERVER-21456

Closed

SERVER-44386 Complete TODO listed in SERVER-21456

Closed

(2 related to)

Activity

People

Assignee:: Siyuan Zhou

Reporter:: Siyuan Zhou

Participants:: Githook User, Siyuan Zhou

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: Nov 13 2015 08:05:52 PM UTC

Updated:: Nov 03 2019 04:54:50 AM UTC

Resolved:: Nov 28 2017 08:34:58 PM UTC