Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-21525

Coverity analysis defect 76757: Redundant test

    XMLWordPrintableJSON

Details

    • Fully Compatible
    • ALL

    Description

      Test always evaluates the same

      Defect 76757 (STATIC_C)
      Checker DEADCODE (subcategory redundant_test)
      File: /src/mongo/s/catalog/replset/replset_dist_lock_manager.cpp
      Function mongo::ReplSetDistLockManager::lock(mongo::OperationContext *, mongo::StringData, mongo::StringData, std::chrono::duration<long, std::ratio<(long)1, (long)1000>>, std::chrono::duration<long, std::ratio<(long)1, (long)1000>>)
      /src/mongo/s/catalog/replset/replset_dist_lock_manager.cpp, line: 311
      At condition "networkErrorRetries < 2", the value of "networkErrorRetries" must be equal to 0.

                      networkErrorRetries < kMaxNumLockAcquireRetries) {

      /src/mongo/s/catalog/replset/replset_dist_lock_manager.cpp, line: 282
      Assigning: "networkErrorRetries" = "0".

                  int networkErrorRetries = 0;

      /src/mongo/s/catalog/replset/replset_dist_lock_manager.cpp, line: 310
      The condition "networkErrorRetries < 2" must be true.

                  if (ShardRegistry::kAllRetriableErrors.count(status.code()) &&

      Attachments

        Activity

          People

            kaloian.manassiev@mongodb.com Kaloian Manassiev
            xgen-internal-coverity Coverity Collector User
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: