Modernize the GeoHash class

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Geo
    • Query Integration
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      In src/mongo/db/geo/hash.cpp:

      Consider making geoBitSets, bitsField, maxField, and minField const.

      Consider using StringData instead of std::string or char* in initFromString, operator+, and appendHashMin to remove unnecessary calls to strlen.

      Consider removing copy constructor and assignment operator, which are identical to what the compiler would produce.

      Consider inlining ==, !=, getHash, and getBits.

            Assignee:
            Unassigned
            Reporter:
            Tess Avitabile (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated: