Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-22378

Remove sync parameter from StorageEngine::flushAllFiles()

XMLWordPrintableJSON

    • Type: Icon: Improvement Improvement
    • Resolution: Won't Fix
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: MMAPv1, Storage, WiredTiger
    • None
    • Storage Execution
    • Integration F (02/01/16), Integration 10 (02/22/16), Integration 11 (03/14/16)
    • None
    • 0
    • None
    • None
    • None
    • None
    • None
    • None

      StorageEngine::flushAllFiles() takes a boolean parameter, sync, which performs synchronous flushing when true and asynchronous flushing when false. However,

      • MMAPv1 on Windows cannot support asynchronous flushing, and using MS_ASYNC in Posix is a no-op (see SERVER-22271).
      • WiredTiger and the other KVEngine-based storage engines all ignore the sync parameter, doing the flush synchronously.
      • RocksDB also ignores the sync parameter.

      As a consequence, there is no longer a need to keep the sync parameter.

            Assignee:
            backlog-server-execution [DO NOT USE] Backlog - Storage Execution Team
            Reporter:
            kyle.suarez@mongodb.com Kyle Suarez (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: