Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-22456

The oplog find query timeout is too low

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical - P2
    • Resolution: Fixed
    • Affects Version/s: 3.2.0
    • Fix Version/s: 3.2.3, 3.3.2
    • Component/s: Replication
    • Labels:
    • Backwards Compatibility:
      Fully Compatible
    • Operating System:
      ALL
    • Backport Completed:

      Description

      Due to a low timeout, it is possible that a mmap sync source will not be able to respond within the timeout (2s in PV0, and electionTimeout/2 = 5s by default).

        Issue Links

          Activity

          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'scotthernandez', u'name': u'Scott Hernandez', u'email': u'scotthernandez@gmail.com'}

          Message: SERVER-22456: use 1min oplog find query timeout
          Branch: master
          https://github.com/mongodb/mongo/commit/d2a10dddb97cb8fa7b208661e1875d30fe796bba

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'scotthernandez', u'name': u'Scott Hernandez', u'email': u'scotthernandez@gmail.com'} Message: SERVER-22456 : use 1min oplog find query timeout Branch: master https://github.com/mongodb/mongo/commit/d2a10dddb97cb8fa7b208661e1875d30fe796bba
          Hide
          xgen-internal-githook Githook User added a comment -

          Author:

          {u'username': u'scotthernandez', u'name': u'Scott Hernandez', u'email': u'scotthernandez@gmail.com'}

          Message: SERVER-22456: use 1min oplog find query timeout

          (cherry picked from commit d2a10dddb97cb8fa7b208661e1875d30fe796bba)
          Branch: v3.2
          https://github.com/mongodb/mongo/commit/94fc167ce1196957f2fcbd17cae27bc78244a30b

          Show
          xgen-internal-githook Githook User added a comment - Author: {u'username': u'scotthernandez', u'name': u'Scott Hernandez', u'email': u'scotthernandez@gmail.com'} Message: SERVER-22456 : use 1min oplog find query timeout (cherry picked from commit d2a10dddb97cb8fa7b208661e1875d30fe796bba) Branch: v3.2 https://github.com/mongodb/mongo/commit/94fc167ce1196957f2fcbd17cae27bc78244a30b
          Hide
          yonido Yoni Douek added a comment -

          Seems like you changed only one usage, but there are other places in code using 'fetcherMaxTimeMS' (in the callback + getmore?).
          you'll also want to fix the comment in line 311

          Show
          yonido Yoni Douek added a comment - Seems like you changed only one usage, but there are other places in code using 'fetcherMaxTimeMS' (in the callback + getmore?). you'll also want to fix the comment in line 311
          Hide
          scotthernandez Scott Hernandez (Inactive) added a comment -

          What was done was intentional and only for the initial find portion, not the getmores, of the query. The timeouts are different due to liveness and heartbeat requirements for failover and elections.

          Show
          scotthernandez Scott Hernandez (Inactive) added a comment - What was done was intentional and only for the initial find portion, not the getmores, of the query. The timeouts are different due to liveness and heartbeat requirements for failover and elections.
          Hide
          milkie Eric Milkie added a comment -

          You are mistaken; the comment in line 311 is correct description of the code.

          We only changed the timeout for issuing the original query. We intentionally did not change the timeout for advancing the cursor.

          Show
          milkie Eric Milkie added a comment - You are mistaken; the comment in line 311 is correct description of the code. We only changed the timeout for issuing the original query. We intentionally did not change the timeout for advancing the cursor.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: