Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-22683

enableMajorityReadConcern option cannot be disabled if specified

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major - P3
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 3.2.4, 3.3.2
        • Component/s: Replication
        • Labels:
        • Backwards Compatibility:
          Fully Compatible
        • Operating System:
          ALL
        • Backport Completed:
        • Sprint:
          Repl 10 (02/19/16)

          Description

              if (params.count("replication.enableMajorityReadConcern")) {
          		 
                  replSettings.setMajorityReadConcernEnabled(true);
          		 
              }

          This code should be using the value of the parameter to call setMajorityReadConcernEnabled, not a hardcoded "true".
          Right now, if you specify {replication

          {enableMajorityReadConcern:false}

          } in a config file, it actually turns the option on.

            Activity

            • Comments
            Ascending order - Click to sort in descending order
            Hide
            Permalink
            xgen-internal-githook Githook User added a comment -

            Author:

            {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

            Message: SERVER-22683 support replication.enableMajorityReadConcern=false in configuration file
            Branch: master
            https://github.com/mongodb/mongo/commit/739f84e691a8659ffef80c6de9124602d32a2d3a

            Show
            xgen-internal-githook Githook User added a comment - Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'} Message: SERVER-22683 support replication.enableMajorityReadConcern=false in configuration file Branch: master https://github.com/mongodb/mongo/commit/739f84e691a8659ffef80c6de9124602d32a2d3a
            Hide
            Permalink
            xgen-internal-githook Githook User added a comment -

            Author:

            {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

            Message: SERVER-22683 support replication.enableMajorityReadConcern=false in configuration file

            (cherry picked from commit 739f84e691a8659ffef80c6de9124602d32a2d3a)
            Branch: v3.2
            https://github.com/mongodb/mongo/commit/37e5edc5ff6f43d582e5eae0570ccbef20ba04a4

            Show
            xgen-internal-githook Githook User added a comment - Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'} Message: SERVER-22683 support replication.enableMajorityReadConcern=false in configuration file (cherry picked from commit 739f84e691a8659ffef80c6de9124602d32a2d3a) Branch: v3.2 https://github.com/mongodb/mongo/commit/37e5edc5ff6f43d582e5eae0570ccbef20ba04a4

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                    Agile