Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-23671

build fails if using system tcmalloc but third party valgrind

XMLWordPrintableJSON

    • Type: Icon: Bug Bug
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • 3.3.5
    • Affects Version/s: 3.3.4
    • Component/s: Build
    • Labels:
      None
    • Fully Compatible
    • ALL
    • Hide

      scons --use-system-tcmalloc should do it, I think.

      Show
      scons --use-system-tcmalloc should do it, I think.

      As you can see here https://launchpadlibrarian.net/251967168/buildlog_ubuntu-xenial-amd64.mongodb_1%3A3.3.3-0ubuntu1_BUILDING.txt.gz a build with --use-system-tcmalloc failed because tcmalloc_server_status_section.cpp could not find valgrind.h. This is a logic failure in src/mongo/utils/SConscript: it only calls tcmspEnv.InjectThirdPartyIncludePaths('valgrind') if using the third party tcmalloc, not if using the third parth valgrind.

      I'll send a PR with a fix in a moment.

            Assignee:
            mark.benvenuto@mongodb.com Mark Benvenuto
            Reporter:
            mwhudson Michael Hudson-Doyle
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: