Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-24702

Remove remnants of ShardingCatalogManagerImpl from ShardingTestFixture

    XMLWordPrintableJSON

Details

    • Icon: Task Task
    • Resolution: Done
    • Icon: Major - P3 Major - P3
    • 3.3.14
    • None
    • Sharding
    • None
    • Fully Compatible
    • Sharding 18 (08/05/16), Sharding 2016-08-29, Sharding 2016-09-19

    Description

      Currently ShardingCatalogTestFixture sets up both a ShardingCatalogClientImpl and a ShardingCatalogManagerImpl. The config shard, however, is still a ShardRemote. That means that any tests using ShardingCatalogManagerImpl will be acting as though the ShardingCatalogManagerImpl were talking to a remote config server, which is never what will happen in non-test code.

      We also have ConfigServerTestFixture, which also sets up both a ShardingCatalogClientImpl and a ShardingCatalogManagerImpl, but with the config server as a LocalShard. This is closer to how things work in prod code. Thus all tests that use ShardingCatalogManagerImpl should be converted to use ConfigServerTestFixture instead of ShardingCatalogTestFixture.

      We should also probably then rename ShardingCatalogTestFixture to ShardingCatalogClientTestFixture.

      Attachments

        Activity

          People

            esha.maharishi@mongodb.com Esha Maharishi (Inactive)
            spencer@mongodb.com Spencer Brody (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: