set Fetcher::_inShutdown immediately after locking in Fetcher::cancel()

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Done
    • Priority: Major - P3
    • 3.3.11
    • Affects Version/s: 3.3.10
    • Component/s: Replication
    • None
    • Fully Compatible
    • ALL
    • Repl 18 (08/05/16)
    • 0
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      There is a race in the new initial sync code where Fetcher::cancel() can be called while we're in a previous batch's _callback() but before the next batch is scheduled. This means that Fetcher::cancel() is called when the callback handle is invalid, and thus Fetcher::_inShutdown is never set to true. The next batch is then scheduled and _inShutdown is never set to false.

            Assignee:
            Judah Schvimer
            Reporter:
            Judah Schvimer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: