Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-25333

Clean up MigrationDestinationManager

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.2, 4.1.2
    • Component/s: Sharding
    • Labels:
    • Backwards Compatibility:
      Fully Compatible
    • Backport Requested:
      v4.0
    • Sprint:
      Sharding 2018-06-04, Sharding 2018-06-18, Sharding 2018-07-16, Sharding 2018-07-30
    • Linked BF Score:
      0

      Description

      Three things:

      fromShard is a connection string – misleading. _recvStartChunk should get a ShardId rather than a connection string, then the MigrationDestinationManager can get connection strings from the ShardRegistry. There's a ScopedDbConnection conn object that shouldn't be used anymore: use the ShardRegistry and Shard.

      Start actually using StartChunkCloneRequest::createFromCommand, which is currently used no where.

      Generally clean up the MigrationDestinationManager – e.g., we have "_from = fromShard" local variable, but pass fromShard through functions anyway.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: