Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-25572

Fix ASAN clean shutdown logic

    XMLWordPrintableJSON

Details

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major - P3 Major - P3
    • 3.3.12
    • 3.3.10
    • Networking
    • None
    • Fully Compatible
    • ALL
    • Hide

      ./buildscripts/resmoke.py --executor sharding_jscore_passthrough jstests/core/all.js # or anything else that isn't blacklisted.

      1. Watch and see that it takes a full 10 seconds before the fixture comes down because a connection is live in shutdown
      Show
      ./buildscripts/resmoke.py --executor sharding_jscore_passthrough jstests/core/all.js # or anything else that isn't blacklisted. Watch and see that it takes a full 10 seconds before the fixture comes down because a connection is live in shutdown
    • Platforms 2016-08-26
    • 0

    Description

      During shutdown a number of things are currently happening that shouldn't be:

      1. The legacy transport layer is failing to actually close sockets in closeAll. It's doing this because the default argument to closeAll is to leave all sockets open on the legacy transport layer (versus to close them on the actual interface header).

      2. The thing we're checking for in shutdown is wrong. It's just that we've left recv in all db workers, rather than that we've left all client workers (so ASAN is occasionally unhappy about "leaks")

      3. Tests rely on external callers to close sockets. when this contract changes, we take an extra 10 seconds to shut down every mongod, making some tests time out.

      Fix this by adding a counter for actual live workers, so we can track when it's safe to shutdown correctly. Also fix the typo

      Attachments

        Activity

          People

            mira.carey@mongodb.com Mira Carey
            mira.carey@mongodb.com Mira Carey
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: