Details
-
Bug
-
Resolution: Done
-
Major - P3
-
None
-
Fully Compatible
-
ALL
-
-
Query 2016-09-19
-
0
Description
The link_version.startswith(version) condition is flawed because it doesn't ensure the minor versions of link_version and version are the same.
urls = [] |
for link_version, link_url in self.links.iteritems(): |
if link_version.startswith(version) or link_version == "v%s-latest" % (version): |
# The 'link_version' is a candidate for the requested 'version' if |
# (a) it is a prefix of the requested version, or if |
# (b) it is the "<branchname>-latest" version and the requested version is for a |
# particular major release. |
if "-" in version: |
# The requested 'version' contains a hyphen, so we only consider exact matches |
# to that version. |
if link_version != version: |
continue |
urls.append((link_version, link_url))
|