Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-26469

remove remaining sharding usages of OldClientWriteContext

    • Type: Icon: Improvement Improvement
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Sharding
    • None
    • Sharding

      it's almost gone from sharding, so we can try to remove it completely:

      src/mongo/db/s/migration_destination_manager.cpp:473:        OldClientWriteContext ctx(txn, _nss.ns());
      src/mongo/db/s/migration_destination_manager.cpp:651:                    OldClientWriteContext cx(txn, _nss.ns());
      src/mongo/db/s/migration_destination_manager.cpp:924:            OldClientWriteContext cx(txn, ns);
      src/mongo/db/s/collection_range_deleter.cpp:60:class OldClientWriteContext;
      

      it still exists elsewhere in many dbtests for query and in mapreduce:

      src/mongo/db/commands/mr.cpp:408:            OldClientWriteContext incCtx(_txn, _config.incLong);
      src/mongo/db/commands/mr.cpp:446:        OldClientWriteContext finalCtx(_txn, _config.outputOptions.finalNamespace);
      src/mongo/db/commands/mr.cpp:474:        OldClientWriteContext tempCtx(_txn, _config.tempNamespace);
      src/mongo/db/commands/mr.cpp:720:        OldClientWriteContext ctx(_txn, ns);
      src/mongo/db/commands/mr.cpp:756:        OldClientWriteContext ctx(_txn, _config.incLong);
      src/mongo/db/commands/mr.cpp:1045:        OldClientWriteContext incCtx(_txn, _config.incLong);
      

            Assignee:
            backlog-server-sharding [DO NOT USE] Backlog - Sharding Team
            Reporter:
            esha.maharishi@mongodb.com Esha Maharishi (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: