Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-26608

$out can attempt to upgrade locks if an error is encountered during a getMore

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Gone away
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Aggregation Framework
    • Labels:
      None
    • Operating System:
      ALL

      Description

      For starters, this can only happen if your batchSize is 0, since $out returns no results and the error needs to take place in a getMore. The following series of events can occur, eventually triggering a dassert, or potentially worse (I don't fully understand the implications of having the flush lock locked in the wrong mode).

      1. An aggregate starts running inside a getMore. The cursor associated with the aggregation is pinned.
      2. An error occurs, throwing a UserException (in my instance an inserted document failed document validation).
      3. This ScopeGuard is destructed, triggering it to clean up the cursor.
      4. GetMoreCmd::cleanupCursor() is called, taking the global, db, and collection lock in IS mode. I believe this is required to access the CursorManager.
      5. ClientCursorPin::deleteUnderlying() is called, triggering kills and destructions eventually leading to the $out stage's destruction.
      6. The $out stage's destructor is triggered, and attempts to clean up the temporary collection it created and partially filled.
      7. The drop command attempts to take the DB lock in X mode, which is an upgrade from the held IS lock, which eventually triggers this dassert().

      I think this can also happen on the 3.2 branch and earlier, but I haven't verified.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: