Details
-
Improvement
-
Status: Closed
-
Major - P3
-
Resolution: Fixed
-
None
-
Fully Compatible
-
Platforms 2016-10-31
Description
The MessagePort::recv class rounds up the size of the buffer it uses to hold a message coming off the network.
There is no good reason to do so, and some reasons to actively not do so, since:
- TCMalloc already groups allocations into size buckets
- The extra allocation wastes 0.5kb on average for each server operation in progress
- ASAN and other tools will see the extra bytes as valid to access, even though they contain garbage data, potentially masking bugs.
We should remove the rounding.