Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-26932

Further improve index_retry.js, index_no_retry.js, and crashAfterStartingIndexBuild failpoint

    XMLWordPrintable

Details

    • Task
    • Status: Closed
    • Minor - P4
    • Resolution: Gone away
    • None
    • None
    • Storage
    • None

    Description

      1. Avoid letting the server continue running if RecoveryUnit::waitUntilDurable() return false.

      if (MONGO_FAIL_POINT(crashAfterStartingIndexBuild)) {
          log() << "Index build interrupted due to 'crashAfterStartingIndexBuild' failpoint. Exiting "
                   "after waiting for changes to become durable.";
          Locker::LockSnapshot lockInfo;
          _txn->lockState()->saveLockStateAndUnlock(&lockInfo);
          if (_txn->recoveryUnit()->waitUntilDurable()) {
              quickExit(EXIT_TEST);
          }
      }
      

      2. Inline the contents of the abortDuringIndexBuild() function and eliminate the unnecessary usage of startParallelShell() in index_retry.js and index_no_retry.js. The changes from SERVER-23510 made it so that creating the background index should synchronously crash the server, so the tests no longer need to use multiple clients.

      Attachments

        Issue Links

          Activity

            People

              backlog-server-execution Backlog - Storage Execution Team
              max.hirschhorn@mongodb.com Max Hirschhorn
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: