Loading...

XML

Word

Printable

JSON

Type: Improvement
Resolution: Done
Priority: Major - P3
Fix Version/s: 4.3.1
Affects Version/s: None
Component/s: Testing Infrastructure
Labels:
None

Backwards Compatibility:
Fully Compatible
Sprint:
Dev Tools 2019-10-07
Linked BF Score:
50
Confidence Status:
None
Work Order:
3
CAR Domain/s:
None

Aha! Reference:
None
Tracking Level:
None
Risk Status:
None
Exec Notes:
None
Goal Name(s):
None
Goal Link:
None

As detailed in ~~SERVER-27897~~, and the linked issues from there, unused RAII objects are often an indication of bugs. To avoid recurrence of this class of bugs, we need additional checking. As max.hirschhorn noted, `clang-tidy` provides just that: http://clang.llvm.org/extra/clang-tidy/checks/misc-unused-raii.html

This ticket is to add such checking.

depends on

SERVER-27897 Remove uses of temporary RAII objects

Closed

related to

SERVER-49800 add use-after-move rule to clang-tidy evergreen builder

Closed

SERVER-50165 parallelize clang-tidy task

Closed

SERVER-51240 Add clang tidy rules to prevent const return by value and (in declarations) const pass by value

Closed

SERVER-54210 add clang-tidy to commit queue tasks

Closed

Assignee:: Andrew Morrow (Inactive)
Reporter:: Geert Bosch
Participants:: Andrew Morrow, Geert Bosch, Githook User
Votes:: 2 Vote for this issue
Watchers:: 13 Start watching this issue

Created:: Feb 13 2017 06:47:43 PM UTC
Updated:: Feb 02 2021 05:00:27 PM UTC
Resolved:: Sep 27 2019 04:55:29 PM UTC
Confidence Status Last Update:: 26/Sep/19 7:58 PM