Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-27984

Add clang-tidy run in addition to lint

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Major - P3
    • Resolution: Fixed
    • None
    • 4.3.1
    • Testing Infrastructure
    • None
    • Fully Compatible
    • Dev Tools 2019-10-07
    • 50

    Description

      As detailed in SERVER-27897, and the linked issues from there, unused RAII objects are often an indication of bugs. To avoid recurrence of this class of bugs, we need additional checking. As max.hirschhorn noted, `clang-tidy` provides just that: http://clang.llvm.org/extra/clang-tidy/checks/misc-unused-raii.html

      This ticket is to add such checking.

      Attachments

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. SERVER-27897 Remove uses of temporary RAII objects

          • Major - P3 - Major loss of function.
          • Closed
          related to

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-49800 add use-after-move rule to clang-tidy evergreen builder

          • Major - P3 - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-50165 parallelize clang-tidy task

          • Major - P3 - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-51240 Add clang tidy rules to prevent const return by value and (in declarations) const pass by value

          • Major - P3 - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SERVER-54210 add clang-tidy to commit queue tasks

          • Major - P3 - Major loss of function.
          • Closed

          Activity

            People

              andrew.morrow@mongodb.com Andrew Morrow
              geert.bosch@mongodb.com Geert Bosch
              Votes:
              2 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: