Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-28353

make ARS actually interruptible from the deadline on the OperationContext

    XMLWordPrintableJSON

Details

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major - P3 Major - P3
    • 3.5.5
    • 3.5.5
    • Sharding
    • None
    • Fully Compatible
    • ALL
    • Sharding 2017-03-27, Sharding 2017-04-17
    • 0

    Description

      The AsyncRequestsSender uses Notification::get(OperationContext*), but does not handle exceptions.

      Notification::get(OperationContext*) calls OperationContext::waitForConditionOrInterrupt(), which uasserts on the return value of OperationContext::waitForConditionOrInterruptNoAssert().

      This uassert generates an exception.

      Since it's uncertain whether every path that will use AsyncRequestsSender is exception-safe, the AsyncRequestsSender should try/catch around its use of Notification::get(OperationContext*) and convert the thrown exception back into a status.

      Eventually, we may choose to make every path exception-safe.

      Attachments

        Activity

          People

            esha.maharishi@mongodb.com Esha Maharishi (Inactive)
            esha.maharishi@mongodb.com Esha Maharishi (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: