Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-28353

make ARS actually interruptible from the deadline on the OperationContext

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: 3.5.5
    • Fix Version/s: 3.5.5
    • Component/s: Sharding
    • Labels:
      None

      Description

      The AsyncRequestsSender uses Notification::get(OperationContext*), but does not handle exceptions.

      Notification::get(OperationContext*) calls OperationContext::waitForConditionOrInterrupt(), which uasserts on the return value of OperationContext::waitForConditionOrInterruptNoAssert().

      This uassert generates an exception.

      Since it's uncertain whether every path that will use AsyncRequestsSender is exception-safe, the AsyncRequestsSender should try/catch around its use of Notification::get(OperationContext*) and convert the thrown exception back into a status.

      Eventually, we may choose to make every path exception-safe.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              esha.maharishi Esha Maharishi
              Reporter:
              esha.maharishi Esha Maharishi
              Participants:
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: