Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-28887

Cleanup KeysCollectionCacheReader/AndUpdater

    XMLWordPrintableJSON

Details

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Major - P3 Major - P3
    • 3.7.2
    • 3.5.7
    • Sharding
    • Fully Compatible
    • Sharding 2018-02-12

    Description

      This refactor ticket aims to split KeysCollectionCacheReaderAndUpdater into KeyGenerator and KeysCollectionCacheReader. To achieve this, we need to:

      • Remove existing KeysCollectionCache.
      • rename KeysCollectionCacheReader to KeysCollectionCache
      • rename KeysCollectionCacheReaderAndUpdater to KeyGenerator
      • change existing code in KeysCollectionManager to always have a KeysCollectionCache and create a KeyGenerator in here and destroy in here

      change KeysCollectionCacheReaderAndUpdater to the following api:

      class KeyGenerator {
          Status generateNewKeysIfNeeded(OperationContext* opCtx);
          // removed the getKey methods, existing callers should call the KeysCollectionCache instance instead.
      };
      

      Attachments

        Activity

          People

            blake.oler@mongodb.com Blake Oler
            randolph@mongodb.com Randolph Tan
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: