[SERVER-29056] InitialSyncer::_startupComponent should reset 'component' before returning CallbackCanceled due to shutdown - MongoDB

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major - P3
Resolution: Fixed
Affects Version/s: 3.4.4, 3.5.6
Fix Version/s: 3.4.6, 3.5.7
Component/s: Replication
Labels:
None

Backwards Compatibility:
Fully Compatible
Backport Completed:

3.4.6
Linked BF Score:
0

Description

_startupComponent currently resets the unique_ptr if the component's startup() returns an error but not when the parent component is shutting down. This usually doesn't pose a problem except when the sub component is holding some resource that needs to be released if we decide not to proceed with calling its startup().

https://github.com/mongodb/mongo/blob/fa2dcc33303dd6a2080c108e121da6984d08a9d6/src/mongo/db/repl/initial_syncer.cpp#L1340


template <typename Component>
Status InitialSyncer::_startupComponent_inlock(Component& component) {
    if (_isShuttingDown_inlock()) {
        return Status(ErrorCodes::CallbackCanceled,
                      "initial syncer shutdown while trying to call startup() on component");
    }
    auto status = component->startup();
    if (!status.isOK()) {
        component.reset();
    }
    return status;
}

Attachments

Issue Links

is related to

SERVER-28214 Recoverable Rollback: Fallback to 3.4 rollback implementation where necessary

Closed

Activity

People

Assignee:: Benety Goh

Reporter:: Benety Goh

Participants:: Benety Goh, Githook User

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: May 03 2017 08:44:28 PM UTC

Updated:: Oct 12 2017 08:55:31 PM UTC

Resolved:: May 05 2017 02:06:33 PM UTC

initial_syncer.cpp
1337	template <typename Component>
1338	Status InitialSyncer::_startupComponent_inlock(Component& component) {
1339	if (_isShuttingDown_inlock()) {
1340	return Status(ErrorCodes::CallbackCanceled,
1341	"initial syncer shutdown while trying to call startup() on component");
1342	}
1343	auto status = component->startup();
1344	if (!status.isOK()) {
1345	component.reset();
1346	}
1347	return status;
1348	}